Re: UCD web service: possible bug of "assign" method

From: Sebastien Derriere <derriere-at-newb6.u-strasbg.fr>
Date: Tue, 29 Nov 2005 18:29:34 +0100


"Ivan Yu. Zolotukhin" wrote:
>
> Hello,
>
> Just want to post some comment on "assign" method of UCD web service, it
> works improperly in my opinion. It returns not UCD actually, but UCD plus
> \n symbol at the end of it. I thought that there is a problem with my
> client, but dump of SOAP conversation proves my guess: there is a '\n'
> symbol at the end of ucd inside <return> element of soap envelope. So all
> clients return something like $real_ucd . "\n", using Perl terminology.
>
> Is it a correct behaviour? I think all the transformations with UCD should
> be left to client side, shouldn't they? Are there similar behaviour of
> other methods of this web service?
>
> If it is not correct, it's better to fix it now, otherwise many clients
> will depened on it. For instance, my client now removes this trailing
> linefeed to insert correct UCD into database.

  Hello,

  Indeed, most of the methods return a trailing '\n' character at the end of the result. But nobody had complained yet about this behaviour.   I'm reluctant to change the behaviour of these methods now, because they may be already implemented in various places, and I guess developers
have added a line of code to remove this character in case they needed to.
And they might be upset to see a working implementation getting wrecked because of a "bug fix".
  Unless there is a large protest against this extra '\n', I'd rather keep the currently available methods as they are, and take care of better documenting the future ones.
  Regards,

Sebastien.

-- 
    _______
   /  ~   /, Sebastien Derriere   mailto:derriere-at-astro.u-strasbg.fr
  / ~~~~ //  Observatoire de Strasbourg    Phone +33 (0) 390 242 444
 /______//   11, rue de l'universite     Telefax +33 (0) 390 242 417
(______(/    F-67000 Strasbourg  France
Received on 2005-11-29Z17:30:18